Skip to content

Use image selector feature in "Deploying application" guides#7013

Merged
openshift-merge-robot merged 12 commits intoredhat-developer:mainfrom
rm3l:6976-deploying-an-application-should-use-image-selector-feature
Aug 2, 2023
Merged

Use image selector feature in "Deploying application" guides#7013
openshift-merge-robot merged 12 commits intoredhat-developer:mainfrom
rm3l:6976-deploying-an-application-should-use-image-selector-feature

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Aug 2, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:
This makes use of the image-name-as-selector feature in the "Deploy an application" guides. It also enhances other places in the same docs, like:

  • syntax highlighting in Dockerfiles
  • highlighting places in the Devfile that need to be modified
  • detailing the "Accessing the application" section

Which issue(s) this PR fixes:
Fixes #6976

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
See all the guides under "Advanced Usage > Deploying application": https://odo-dev-pr-7013.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/docs/user-guides/advanced/deploy/

@netlify
Copy link

netlify bot commented Aug 2, 2023

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit f5856fb
😎 Deploy Preview https://odo-dev-pr-7013.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Aug 2, 2023
@rm3l rm3l temporarily deployed to internal August 2, 2023 12:01 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from feloy and kadel August 2, 2023 12:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l changed the title Use image selector feature in "Deploying an application" guides Use image selector feature in "Deploying application" guides Aug 2, 2023
@odo-robot
Copy link

odo-robot bot commented Aug 2, 2023

Kubernetes Docs Tests on commit d41364e finished successfully.
View logs: TXT HTML

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6c1c8b2 into redhat-developer:main Aug 2, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal August 2, 2023 13:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying an Application should use image selector feature

3 participants