Skip to content

Set Save button on top, enable it only when devfile changed#7015

Merged
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
feloy:feature-6978/ui-change-state
Aug 3, 2023
Merged

Set Save button on top, enable it only when devfile changed#7015
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom
feloy:feature-6978/ui-change-state

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Aug 3, 2023 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6978
Fixes #7003

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 3, 2023
@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c35b1a7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64cb59d1b7cb5700092ab53e

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 3, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l August 3, 2023 07:05
@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 6c1c8b2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit e189db3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

NoCluster Tests on commit e189db3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Unit Tests on commit e189db3 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6978/ui-change-state branch from 82afb3a to c35b1a7 Compare August 3, 2023 07:39
@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Validate Tests on commit e189db3 finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Kubernetes Tests on commit e189db3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Windows Tests (OCP) on commit e189db3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

OpenShift Tests on commit e189db3 finished with errors.
View logs: TXT HTML

@feloy feloy changed the title [wip] Set Save button on top, enable it only when devfile changed Set Save button on top, enable it only when devfile changed Aug 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 3, 2023
@rm3l rm3l mentioned this pull request Aug 3, 2023
Merged
3 tasks
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 3, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 3, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test

[FAILED] [4.728 seconds]
odo create/delete/list/set namespace/project tests delete project when force-deleting a valid project [BeforeEach] should successfully delete the project synchronously with --wait
  [BeforeEach] /go/odo_1/tests/integration/cmd_namespace_test.go:74
  [It] /go/odo_1/tests/integration/cmd_namespace_test.go:104

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test

[FAILED] [4.728 seconds]
odo create/delete/list/set namespace/project tests delete project when force-deleting a valid project [BeforeEach] should successfully delete the project synchronously with --wait
 [BeforeEach] /go/odo_1/tests/integration/cmd_namespace_test.go:74
 [It] /go/odo_1/tests/integration/cmd_namespace_test.go:104

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 84bfb22 into redhat-developer:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels

kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ui: a message to update the devfile appears when the Devfile is saved [UI] Compute the state of changes and enable the Save button accordingly

3 participants

@feloy @rm3l @openshift-merge-robot