Remove kubeconfig flag#7017
Merged
openshift-merge-robot merged 4 commits intoredhat-developer:mainfrom Aug 4, 2023
Merged
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… of files and this is done by clientcmd library
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Member
So I guess this should also fix #6700, right? |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rm3l
reviewed
Aug 4, 2023
Member
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
Since this is a user-facing issue that can potentially confuse them, can we add a test to check that the --kubeconfig flag is no longer exposed?
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
odo list, as this value can be a list of files. The check of the KUBECONFIG value is done by theclientcmdlibrary used to get the Kubernetes configWhich issue(s) this PR fixes:
Fixes #5732
Fixes #6700
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: