[UI] Make sure form validation displays non-valid fields as red in all forms#7064
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Skipping CI for Draft Pull Request. |
ccad415 to
4879b59
Compare
41083ef to
7832533
Compare
This covers the following forms: - Add commands when adding a Composite Command Co-authored-by: Philippe Martin <[email protected]>
This covers the following forms: - Add Environment variables in Create Container - Add Deployment annotations in Create Container - Add Service annotations in Create Container Co-authored-by: Philippe Martin <[email protected]>
This covers the following forms: - Add Command in Create Container - Add Args in Create Container - Add Args in Create Image Co-authored-by: Philippe Martin <[email protected]>
This covers the following forms: - Select or Create container in Add Exec Command - Select or create image component in Add Image Command - Select or create Resource in Add Apply command Co-authored-by: Philippe Martin <[email protected]>
This covers the following forms: - Select or Create volume mount in Create container Co-authored-by: Philippe Martin <[email protected]>
7832533 to
b35c5ca
Compare
Co-authored-by: Philippe Martin <[email protected]>
|
|
||
| cy.getByDataCy('volume-mount-add').click(); | ||
| cy.getByDataCy('volume-mount-path-0').type("/mnt/vol1"); | ||
| cy.getByDataCy('volume-mount-path-0').type("/mnt/vol1", {force: true}); |
There was a problem hiding this comment.
Not sure why, but I had to make Cypress forcibly bypass some checks with force: true. Otherwise, Cypress would complain that the element was covered by another one:
CypressError: Timed out retrying after 4000ms: `cy.type()` failed because this element:
`<input _ngcontent-xcd-c181="" formcontrolname="path" matinput="" class="mat-mdc-input-element ng-tns-c84-53 ng-untouched ng-pristine ng-invalid mat-mdc-form-field-input-control mdc-text-field__input cdk-text-field-autofill-monitored" ng-reflect-name="path" data-cy="volume-mount-path-0" id="mat-input-32" required="" aria-required="true">`
is being covered by another element:
`<span aria-hidden="true" class="mat-mdc-form-field-required-marker mdc-floating-label--required ng-tns-c84-53 ng-star-inserted"></span>`
Fix this problem, or use {force: true} to disable error checking.
|
Kudos, SonarCloud Quality Gate passed! |
UI-only PR, so not related to the failures here. /override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests |
|
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. /override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. /override windows-integration-test/Windows-test |
|
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |








What type of PR is this:
/area Web-UI
What does this PR do / why we need it:
This makes sure invalid fields are highlighted as red in all forms.
Add an Exec Command
Add an Image Command
Add an Apply Command
Add a Composite Command
Add a new container
Add a new image
Add a new resource
Add a new volume
Which issue(s) this PR fixes:
Fixes #7054
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: