Skip to content

[ui] Fix Resource URI button not checked#7070

Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:bugfix/resource-uri-checked
Sep 4, 2023
Merged

[ui] Fix Resource URI button not checked#7070
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom
feloy:bugfix/resource-uri-checked

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Sep 4, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit f504f9e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f5e5b610df65000823fd9d
😎 Deploy Preview https://deploy-preview-7070--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 4, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l September 4, 2023 13:37
@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Sep 4, 2023
@rm3l rm3l changed the title [u] Fix Resource URI button not checked [ui] Fix Resource URI button not checked Sep 4, 2023
@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Kubernetes Docs Tests on commit 8051843 finished successfully.
View logs: TXT HTML

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 4, 2023
@rm3l rm3l force-pushed the bugfix/resource-uri-checked branch from 804f89d to f504f9e Compare September 4, 2023 14:12
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 4, 2023
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just generated and pushed the static UI files, for the Check generated files workflow to pass ;-)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added this to the v3.15.0 🚀 milestone Sep 4, 2023
@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

NoCluster Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

OpenShift Unauthenticated Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Unit Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Validate Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Kubernetes Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Windows Tests (OCP) on commit 2fe42cb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

OpenShift Tests on commit 2fe42cb finished successfully.
View logs: TXT HTML

@openshift-merge-robot openshift-merge-robot merged commit 03c109a into redhat-developer:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants