Display icon in metadata#7078
Merged
openshift-merge-robot merged 2 commits intoredhat-developer:mainfrom Sep 8, 2023
Merged
Conversation
openshift-ci
bot
added
the
kind/feature
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
approved these changes
Sep 8, 2023
Member
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
I just noticed that the Icon can also be a relative path in the project, and we won't preview such relative paths. But I think it is fine for now.
openshift-ci
bot
added
the
lgtm
feloy
force-pushed
the
feature-7072/display-icon
branch
from
d6207ab to
54a7cc4
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
approved these changes
Sep 8, 2023
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #7072
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: