Skip to content

Ignore devstate when existing process name is not odo + delete devstate files with odo delete component#7090

Merged
openshift-merge-robot merged 9 commits intoredhat-developer:mainfrom
feloy:feature-6994/delete-orphan-devstates
Sep 20, 2023
Merged

Ignore devstate when existing process name is not odo + delete devstate files with odo delete component#7090
openshift-merge-robot merged 9 commits intoredhat-developer:mainfrom
feloy:feature-6994/delete-orphan-devstates

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Sep 18, 2023 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6994

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit b7a3720
😎 Deploy Preview https://odo-dev-pr-7090.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 18, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l September 18, 2023 07:54
@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

NoCluster Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

Unit Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

Validate Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

Kubernetes Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

Windows Tests (OCP) on commit 63c48ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

OpenShift Tests on commit 63c48ca finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch from 148cb9f to 16c77cf Compare September 18, 2023 08:32
@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch from 16c77cf to b5d584b Compare September 18, 2023 08:41
@odo-robot
Copy link

odo-robot bot commented Sep 18, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 9e1698b finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch 2 times, most recently from db638ee to 058590c Compare September 19, 2023 07:46
@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch from 058590c to 1fd3888 Compare September 19, 2023 08:00
@feloy feloy changed the title [wip] Ignore devstate when existing process name is not odo Ignore devstate when existing process name is not odo + delete devstate files with odo delete component Sep 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 19, 2023
@feloy feloy temporarily deployed to internal September 19, 2023 09:13 — with GitHub Actions Inactive
@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch from 18b42b6 to 79b83dc Compare September 19, 2023 09:48
@feloy feloy temporarily deployed to internal September 19, 2023 09:48 — with GitHub Actions Inactive
@feloy feloy removed the request for review from kadel September 19, 2023 09:49
@feloy feloy closed this Sep 19, 2023
@feloy feloy reopened this Sep 19, 2023
@feloy feloy temporarily deployed to internal September 19, 2023 11:45 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal September 19, 2023 12:25 — with GitHub Actions Inactive
@feloy feloy force-pushed the feature-6994/delete-orphan-devstates branch from 4e11fa6 to 0c3e30f Compare September 19, 2023 12:50
@feloy feloy temporarily deployed to internal September 19, 2023 12:50 — with GitHub Actions Inactive
@feloy
Copy link
Contributor Author

feloy commented Sep 20, 2023

I still need to work on this issue on Windows

[FAILED] [190.046 seconds]
odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false when killing odo dev and another process replaces it [It] should restart a new session successfully

@feloy feloy temporarily deployed to internal September 20, 2023 09:01 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

rm3l
rm3l approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2023
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Sep 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0f828ec into redhat-developer:main Sep 20, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal September 20, 2023 12:20 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels

area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.odo/devstate.* files with a non-odo pid should not block running odo dev

3 participants

@feloy @rm3l @openshift-merge-robot