Make sure a Deploy command is present in the Devfile before auto-applying components#7093
Merged
Conversation
openshift-ci
bot
added
kind/bug
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Sep 20, 2023
openshift-ci
bot
added
the
lgtm
rm3l
deleted the
6743-odo-deploy-auto-started-components-e.g.-with-deploybydefault-true-are-applied-even-if-devfile-has-no-deploy-command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area deploy
What does this PR do / why we need it:
When the Devfile does not have any
deploycommand but contains some components that are auto-applied (e.g., withautoBuildordeployByDefaultset totrue),odo deploywill try to apply them before ending up complaining that it could not find anydeploycommand.This PR makes sure to check this before applying anything.
See #6743 for more context.
Which issue(s) this PR fixes:
Fixes #6743
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See #6743 for the repro steps.