Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Support spec v1beta1 resources#1176

Merged
openshift-merge-robot merged 8 commits intoredhat-developer:masterfrom
sadlerap:spec-v1beta1-resources
Aug 10, 2022
Merged

Support spec v1beta1 resources#1176
openshift-merge-robot merged 8 commits intoredhat-developer:masterfrom
sadlerap:spec-v1beta1-resources

Conversation

@sadlerap
Copy link
Contributor

Implements support for spec/v1beta1 resources.

Changes

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@sadlerap sadlerap added this to the 1.2.0 milestone Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from baijum and pmacik June 21, 2022 19:52
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch from 706a046 to c652c9c Compare June 22, 2022 20:07
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1176 (5c3f3e4) into master (0bbbfbf) will decrease coverage by 0.06%.
The diff coverage is 16.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
- Coverage   58.02%   57.96%   -0.07%     
==========================================
  Files          33       33              
  Lines        2835     2838       +3     
==========================================
  Hits         1645     1645              
- Misses       1029     1032       +3     
  Partials      161      161              
Impacted Files Coverage Δ
.../v1beta1/clusterworkloadresourcemapping_webhook.go 86.58% <ø> (ø)
apis/spec/v1beta1/servicebinding_webhook.go 58.62% <0.00%> (ø)
apis/spec/v1beta1/zz_generated.deepcopy.go 12.06% <12.06%> (ø)
apis/spec/v1beta1/servicebinding_types.go 20.68% <20.68%> (ø)
...ec/v1beta1/clusterworkloadresourcemapping_types.go 100.00% <100.00%> (ø)
pkg/reconcile/pipeline/context/impl.go 66.07% <100.00%> (ø)
...kg/reconcile/pipeline/context/spec_binding_impl.go 68.96% <100.00%> (ø)
pkg/reconcile/pipeline/mapping.go 67.91% <100.00%> (ø)
...c/v1alpha3/clusterworkloadresourcemapping_types.go
apis/spec/v1alpha3/servicebinding_types.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbbfbf...5c3f3e4. Read the comment docs.

@sadlerap
Copy link
Contributor Author

/retest

1 similar comment
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch 4 times, most recently from 4798221 to 96bd249 Compare June 27, 2022 17:30
@sadlerap sadlerap marked this pull request as ready for review June 27, 2022 17:57
@openshift-ci openshift-ci bot requested a review from shruthihub June 27, 2022 17:57
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch 5 times, most recently from 7bc5958 to e6b2b74 Compare June 27, 2022 21:11
@sadlerap sadlerap marked this pull request as draft June 28, 2022 20:30
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch from 84f6f4f to c8d8e94 Compare June 30, 2022 16:54
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch 3 times, most recently from 2e948c6 to ae2ebfd Compare July 20, 2022 21:19
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch 3 times, most recently from 9d56b2b to bdcf95d Compare July 25, 2022 19:58
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch 4 times, most recently from 52260ae to 1d59753 Compare July 29, 2022 19:22
@sadlerap sadlerap marked this pull request as ready for review July 29, 2022 19:25
@openshift-ci openshift-ci bot requested a review from dperaza4dustbit July 29, 2022 19:25
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch from 65ec5cc to 5b73044 Compare August 9, 2022 21:29
@sadlerap sadlerap requested a review from baijum August 9, 2022 21:29
Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the spec-v1beta1-resources branch from 5b73044 to 5c3f3e4 Compare August 9, 2022 22:05
@baijum
Copy link
Contributor

baijum commented Aug 10, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c233e02 into redhat-developer:master Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants