This repository was archived by the owner on Jun 26, 2024. It is now read-only.
fix(ci): collect kube resources and split acceptance testing jobs#1189
Merged
openshift-merge-robot merged 1 commit intoredhat-developer:masterfrom Jul 27, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 33 33
Lines 2839 2839
=======================================
Hits 1649 1649
Misses 1029 1029
Partials 161 161 Continue to review full report at Codecov.
|
Contributor
|
/lgtm |
ffaa8e3 to
f7239cc
Compare
f7239cc to
5f6c7cb
Compare
Signed-off-by: Pavel Macík <[email protected]>
5f6c7cb to
7943cea
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 24, 2022
…eloper#1189) Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 25, 2022
…eloper#1189) Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 26, 2022
…eloper#1189) Signed-off-by: Pavel Macík <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík [email protected]
Currently, when acceptance tests fail, the kube resources are not collected and archived by GH actions for debug purposes.
Additionally, one of the acceptance tests started to fail recently in the Kubernetes with OLM job due to too many pods being created in the minikube. That prevented creation of the pods for the test which caused the test to fail.
Changes
This PR:
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.