This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Expose binding secret without requiring a workload#1206
Merged
openshift-merge-robot merged 1 commit intoredhat-developer:masterfrom Aug 25, 2022
Merged
Expose binding secret without requiring a workload#1206openshift-merge-robot merged 1 commit intoredhat-developer:masterfrom
openshift-merge-robot merged 1 commit intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
+ Coverage 57.96% 58.05% +0.08%
==========================================
Files 33 33
Lines 2838 2844 +6
==========================================
+ Hits 1645 1651 +6
Misses 1032 1032
Partials 161 161
Continue to review full report at Codecov.
|
sadlerap
force-pushed
the
early-binding-name
branch
2 times, most recently
from
c194867 to
33aa224
Compare
Signed-off-by: Andy Sadler <[email protected]>
sadlerap
force-pushed
the
early-binding-name
branch
from
33aa224 to
0e9c51e
Compare
baijum
reviewed
Aug 24, 2022
baijum
reviewed
Aug 24, 2022
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Sadler [email protected]
Changes
/kind enhancement
This exposes the relevant binding secret without requiring a workload to be present.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.