Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

cherry-pick(release-v1.3.x): Compare various KPIs to the threshold values and fail if any is crossed#1276

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.3.xfrom
service-binding-operator-bot:cherry-pick_release-v1.3.x_c6777eaf_6a64fb12-dd02-415b-a0d8-8ea014fc8f3c
Oct 19, 2022
Merged

cherry-pick(release-v1.3.x): Compare various KPIs to the threshold values and fail if any is crossed#1276
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.3.xfrom
service-binding-operator-bot:cherry-pick_release-v1.3.x_c6777eaf_6a64fb12-dd02-415b-a0d8-8ea014fc8f3c

Conversation

@service-binding-operator-bot
Copy link
Collaborator

Signed-off-by: Pavel Macík [email protected]

Changes

This PR:

  • Introduces test-performance-thresholds Makefile targed that compares various vaules from kpi.yaml generated by make test-performance-collect-kpi to the threshold values defined in environment variables TEST_PERFORMANCE_AVG_MEMORY, TEST_PERFORMANCE_MAX_MEMORY, TEST_PERFORMANCE_AVG_CPU, TEST_PERFORMANCE_MAX_CPU. If any of the threshold is crossed it fails.
  • The test-performance-thresholds is to be executed as part of performance* OpenShift CI jobs ([rhd-sbo] Add periodic (weekly) jobs to run performance tests openshift/release#33192) (after the test-performance-collect-kpi step) and fails the job if any of the thresholds is crossed.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 18, 2022
@openshift-ci openshift-ci bot requested review from sadlerap and shruthihub October 18, 2022 23:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1276 (f4388cb) into release-v1.3.x (7ae0d7d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1276   +/-   ##
===============================================
  Coverage           58.06%   58.06%           
===============================================
  Files                  33       33           
  Lines                2797     2797           
===============================================
  Hits                 1624     1624           
  Misses               1018     1018           
  Partials              155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae0d7d...f4388cb. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 186b0ef into redhat-developer:release-v1.3.x Oct 19, 2022
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.3.x_c6777eaf_6a64fb12-dd02-415b-a0d8-8ea014fc8f3c branch October 19, 2022 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants