Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

cherry-pick(release-v1.3.x): Stop using deprecated features in GH actions#1285

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.3.xfrom
service-binding-operator-bot:cherry-pick_release-v1.3.x_6eb10a5b_29349f6a-80ce-4562-8473-a38c10c30686
Oct 22, 2022
Merged

cherry-pick(release-v1.3.x): Stop using deprecated features in GH actions#1285
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.3.xfrom
service-binding-operator-bot:cherry-pick_release-v1.3.x_6eb10a5b_29349f6a-80ce-4562-8473-a38c10c30686

Conversation

@service-binding-operator-bot
Copy link
Collaborator

Signed-off-by: Pavel Macík [email protected]

Github Actions give the following warning about deprecating node12 based actions:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: ...

and the following warning about deprecating use of set-output command:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Changes

This PR:

  • Updates version of actions that use node12 to versions that use node16.
  • Replaces usage of set-outout command by writting to the new GITHUB_OUTPUT environment variable

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 22, 2022
@openshift-ci openshift-ci bot requested review from filariow and shruthihub October 22, 2022 14:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #1285 (02b7ce0) into release-v1.3.x (9b0b6f2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1285   +/-   ##
===============================================
  Coverage           58.06%   58.06%           
===============================================
  Files                  33       33           
  Lines                2797     2797           
===============================================
  Hits                 1624     1624           
  Misses               1018     1018           
  Partials              155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0b6f2...02b7ce0. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit ae32312 into redhat-developer:release-v1.3.x Oct 22, 2022
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.3.x_6eb10a5b_29349f6a-80ce-4562-8473-a38c10c30686 branch October 22, 2022 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants