Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

cherry-pick(release-v1.4.x): test: retry app creation on failure#1489

Merged
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.4.xfrom
service-binding-operator-bot:cherry-pick_release-v1.4.x_e66264b9_666dfb7d-bbbf-452a-b452-c2a15b421423
Aug 25, 2023
Merged

cherry-pick(release-v1.4.x): test: retry app creation on failure#1489
openshift-merge-robot merged 1 commit intoredhat-developer:release-v1.4.xfrom
service-binding-operator-bot:cherry-pick_release-v1.4.x_e66264b9_666dfb7d-bbbf-452a-b452-c2a15b421423

Conversation

@service-binding-operator-bot
Copy link
Collaborator

Changes

This was causing test failures in CI.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

This was causing test failures in CI.

Signed-off-by: Andy Sadler <[email protected]>
@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch labels Aug 25, 2023
@openshift-ci openshift-ci bot requested review from baijum and filariow August 25, 2023 04:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1489 (44a5b19) into release-v1.4.x (ec6e194) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.4.x    #1489   +/-   ##
===============================================
  Coverage           58.16%   58.16%           
===============================================
  Files                  35       35           
  Lines                3014     3014           
===============================================
  Hits                 1753     1753           
  Misses               1093     1093           
  Partials              168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6e194...44a5b19. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit f01d55b into redhat-developer:release-v1.4.x Aug 25, 2023
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.4.x_e66264b9_666dfb7d-bbbf-452a-b452-c2a15b421423 branch August 25, 2023 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants