Fix potential negative index in load balancers#6928
Merged
mrniko merged 1 commit intoredisson:masterfrom Dec 31, 2025
Merged
Conversation
mrniko
requested changes
Dec 30, 2025
| } | ||
|
|
||
| int ind = Math.abs(index.incrementAndGet() % clientsCopy.size()); | ||
| int ind = (index.incrementAndGet() & 0x7FFFFFFF) % clientsCopy.size(); |
Member
There was a problem hiding this comment.
Consider using Math.floorMod instead
Signed-off-by: 高春晖 <[email protected]>
GaoSSR
force-pushed
the
fix-math-abs-overflow
branch
from
dc4f3d8 to
7274cbf
Compare
Contributor
Author
|
Done, thanks for the suggestion! |
Contributor
Author
|
Excuse me, would it be possible to get to know you? I'm interested in contributing more to Redisson. looking forward to learning from you@mrniko |
Member
|
Sure. Which contact should I use? |
Member
|
Thanks for contribution |
Contributor
Author
|
You can reach me via email: [email protected]，I followed you on GitHub、Looking forward to contributing more to Redisson！ @mrniko |
Member
|
I have sent an email |
Contributor
Author
|
Email sent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Math.abs(Integer.MIN_VALUE) returns negative value, which may cause ArrayIndexOutOfBoundsException.