Extend customization#585
Closed
ramlmn wants to merge 1 commit intorefined-github:masterfrom
ramlmn:add-options
Closed
Extend customization#585ramlmn wants to merge 1 commit intorefined-github:masterfrom ramlmn:add-options
ramlmn wants to merge 1 commit intorefined-github:masterfrom
ramlmn:add-options
Conversation
Member
|
From the readme:
Probably better to open issues about this in the future as we're unlikely to add options unless it's something that is highly contentious. |
Member
|
Author
|
Works for me 😊. You may close this PR if its so. |
fregante
reviewed
Jul 7, 2017
| export default async () => { | ||
| const myUsername = getUsername(); | ||
| const cache = (await getCachedUsers())[storageKey]; | ||
| const cache = (await getCachedUsers())[storageKey] || {}; |
Member
There was a problem hiding this comment.
Please send this line as a separate PR so we can get that in ASAP :)
fregante
reviewed
Jul 7, 2017
| const username = getUsername(); | ||
|
|
||
| markUnread.setup(); | ||
| // Things that we want to do only when the user is logged in |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sindresorhus @bfred-it This PR needs some review. WDYT?