Conversation
| Healthcheck *HealthConfig `json:",omitempty"` // Healthcheck describes how to check the container is healthy | ||
| ArgsEscaped bool `json:",omitempty"` // True if command is already escaped (meaning treat as a command line) (Windows specific). | ||
| Image string // Name of the image as it was passed by the operator (e.g. could be symbolic) | ||
| Platform v1.Platform `json:"-"` |
There was a problem hiding this comment.
Wondering if this one should go into HostConfig (not Config) 🤔 (haven't fully thought about it yet). If it's in HostConfig then perhaps we can also persist it to disk (i.e., remove the json:"-"), but not sure if that's needed.
There was a problem hiding this comment.
Persisting the Platform is needed for restoring the container after daemon restart.
Since the platform is host-dependent, I think it would indeed be a better fit for HostConfig.
|
If you want this to work the same way the current (They're very confusingly named, but the difference is that |
|
An easy way to test that would be to use a value like |
ndeloof
force-pushed
the
run_platform
branch
2 times, most recently
from
662e87f to
24c6c0a
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
|
Upstreamed by: moby#44958 |
5 participants
introduce ability to select platform for image being ran