SSE feature: remove inline assembly + don't set reserved bits#105
Merged
phil-opp merged 1 commit intorust-osdev:masterfrom Apr 15, 2020
Merged
SSE feature: remove inline assembly + don't set reserved bits#105phil-opp merged 1 commit intorust-osdev:masterfrom
phil-opp merged 1 commit intorust-osdev:masterfrom
Conversation
Member
Freax13
commented
Apr 3, 2020
Freax13
commented
- get rid of inline assembly
- for some reason the previous version also set bits 9 & 10 in Cr0. according to the developer manual bits 5-16 are reserved
phil-opp
changed the title
Member
Member
|
Given that this change only affects the SSE feature and nobody objected it, I'm going to merge it. After all, setting bits 9 and 10 seems like an accident to me. Thanks for the PR, @Freax13! |
phil-opp
approved these changes
Apr 15, 2020
phil-opp
added a commit
that referenced
this pull request
Apr 15, 2020
Member
|
Published as version 0.9.1 |
Contributor
|
I'm honestly not sure myself. The OSDev Wiki listed the code I added
to enable SSE -- I didn't write it, though I probably should have (I
need ASM practice :)). Perhaps its worth asking on the OSDev Forum?
…On 4/15/20, Philipp Oppermann ***@***.***> wrote:
Published as version 0.9.1
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#105 (comment)
--
Signed,
Ethin D. Probst
|
Member
|
Thanks for clarifying! I think as long as it still works, setting these bits was likely a copy&paste error. |
vinaychandra
pushed a commit
to vinaychandra/bootloader
that referenced
this pull request
May 25, 2020
vinaychandra
pushed a commit
to vinaychandra/bootloader
that referenced
this pull request
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.