Skip to content

rename _improper_ctypes_check functions#122

Merged
phil-opp merged 1 commit intorust-osdev:masterfrom
Freax13:fix-dupplicate-improper-ctype
Jun 28, 2020
Merged

rename _improper_ctypes_check functions#122
phil-opp merged 1 commit intorust-osdev:masterfrom
Freax13:fix-dupplicate-improper-ctype

Conversation

@Freax13
Copy link
Member

@Freax13 Freax13 commented Jun 24, 2020

rustc seems to have added a warning for dupplicate extern functions with different signatures:

warning: `_improper_ctypes_check` redeclared with a different signature
   --> src/bootinfo/mod.rs:119:5
    |
119 |     fn _improper_ctypes_check(_boot_info: BootInfo);
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this signature doesn't match the previous declaration
    | 
   ::: src/bootinfo/memory_map.rs:235:5
    |
235 |     fn _improper_ctypes_check(_boot_info: MemoryMap);
    |     ------------------------------------------------- `_improper_ctypes_check` previously declared here
    |
    = note: `#[warn(clashing_extern_decl)]` on by default
    = note: expected `unsafe extern "C" fn(bootinfo::memory_map::MemoryMap)`
               found `unsafe extern "C" fn(bootinfo::BootInfo)`

this pr simply renames the functions to get rid of the warning

@phil-opp
Copy link
Member

Thank you!

@phil-opp phil-opp merged commit 5d231b6 into rust-osdev:master Jun 28, 2020
phil-opp added a commit that referenced this pull request Jun 28, 2020
@phil-opp
Copy link
Member

Published as version 0.9.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants