Conversation
There was a problem hiding this comment.
For the BIOS video mode, the crate actually does set it up from what I see, I personally have not tried it but you can see it right here:
Line 131 in bc6c1bd
|
Read through |
|
Just updated the PR to current |
|
Sorry for the delay and thanks a lot for tackling this! Looks good overall. Some ideas for improvements:
|
|
Alright, got both of them done! UEFI now correctly treats it as minima (+ rename to |
|
@phil-opp Any updates? This is ready for merge. |
phil-opp
left a comment
There was a problem hiding this comment.
Thanks for the ping! The code looks good to me, thanks a lot! Have you tested both the BIOS and UEFI variants in QEMU?
It seems like the CI did not start for some reason. Could you push an additional dummy commit (or rebase the PR) to trigger it?
|
I pushed another commit, however GitHub is telling me that the CI workflow is awaiting approval ("First-time contributors need a maintainer to approve running workflows", it links to this article). |
|
Thanks! |
|
Published as v0.10.9 |
This pull request adds
minimum_framebuffer_heightandminimum_framebuffer_widthto the bootloader configuration, and makes the UEFI/BIOS bootloader select and set a GOP/VESA mode with those parameters if one is available.Some things I'm not quite happy with yet, but am unsure how to fix:This does handle BIOS/VESA. I sadly don't have much knowledge of x86 assembly and don't think I'd be able to add thisConfiggets written twice now, so thatbin/uefi.rshas access to the config. Seems not ideal, but unsure how to improve this.This is my first PR and I hope it is useful. Thank you for this great project! It has been a great help in learning about OS development.