Merged
Conversation
Member
|
Thanks a lot for the PR, looks good overall! I'm happy to merge it once you think it's ready, just let me know. |
Member
Author
I'll add some more comments, but after that it should be done |
Member
Author
It's ready now! 🎉 |
phil-opp
approved these changes
May 27, 2022
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Looks good! I left two minor annotations, then we can merge.
Co-authored-by: Philipp Oppermann <[email protected]>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements a UEFI PXE bootloader by extending the existing UEFI bootloader to load a kernel from a TFTP server if the DevicePath of the LoadedImage has a device implementing PXE BaseCode protocol.
This pr needs some unreleased new features of theuefi-rscrate, so we'll have to wait for a new release before merging this branch (I switched theuefi-rsdependency to use the master branch for now). This is the reason I'm marking the pr as a draft.Related to #87