fb/logger: bump noto-sans-mono-bitmap + improvements#267
Merged
phil-opp merged 1 commit intorust-osdev:mainfrom Oct 10, 2022
Merged
fb/logger: bump noto-sans-mono-bitmap + improvements#267phil-opp merged 1 commit intorust-osdev:mainfrom
phil-opp merged 1 commit intorust-osdev:mainfrom
Conversation
phip1611
force-pushed
the
fb-logger-noto-sans-mono-bitmap-bump
branch
from
3ca83e2 to
508adeb
Compare
phip1611
commented
Oct 1, 2022
phip1611
commented
Oct 1, 2022
phip1611
force-pushed
the
fb-logger-noto-sans-mono-bitmap-bump
branch
5 times, most recently
from
0d9995b to
2cb3a8f
Compare
Contributor
|
Looks great! |
phip1611
force-pushed
the
fb-logger-noto-sans-mono-bitmap-bump
branch
from
2cb3a8f to
113faf6
Compare
phil-opp
reviewed
Oct 2, 2022
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Looks good to me, I like the new crate features!
phip1611
force-pushed
the
fb-logger-noto-sans-mono-bitmap-bump
branch
from
113faf6 to
ecd9e39
Compare
phip1611
changed the title
Member
Author
this is now ready to merge! |
phip1611
commented
Oct 7, 2022
| [package.metadata.release] | ||
| dev-version = false | ||
| pre-release-replacements = [ | ||
| { file="Changelog.md", search="# Unreleased", replace="# Unreleased\n\n# {{version}} – {{date}}", exactly=1 }, |
Member
Author
There was a problem hiding this comment.
yikes, my IDE did this automatically
phip1611
commented
Oct 7, 2022
| [build-dependencies] | ||
| llvm-tools-build = { version = "0.1", optional = true, package = "llvm-tools" } | ||
| toml = { version = "0.5.1", optional = true } | ||
| serde = { version = "1.0", features = ["derive"], optional = true} |
Member
Author
There was a problem hiding this comment.
yikes, my IDE did this automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Update
This is now ready for merge.
Original Post
I'm the author of the noto-sans-mono-bitmap-crate and about to release
0.2.0with breaking changes and many improvements (CHANGELOG).As the bootloader crate is the only/the biggest user, I'd like to leave room for API discussions before I release the crate.
This MR bumps the
noto-sans-mono-bitmapto 0.2.0 (unreleased yet) and performs several other small improvements to the framebuffer logger.Any comments? If there are no comments, I'll release the crate in 2-4 days and switch this MR from draft state to ready
What's new?
Example
Please note the
�fallback character in theBIOS bootlogging message, which is also new.