Add support for adding a ramdisk to the disk image#301
Closed
jasoncouture wants to merge 3 commits intorust-osdev:mainfrom
Closed
Add support for adding a ramdisk to the disk image#301jasoncouture wants to merge 3 commits intorust-osdev:mainfrom
jasoncouture wants to merge 3 commits intorust-osdev:mainfrom
Conversation
jasoncouture
force-pushed
the
ramdisk_feature
branch
from
5685cda to
96abe5e
Compare
jasoncouture
force-pushed
the
ramdisk_feature
branch
from
8c6294a to
f9033f8
Compare
Merged
phil-opp
reviewed
Jan 2, 2023
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks for submitting, looks good overall! I left some inline comments below.
Comment on lines
+159
to
+161
| if has_rd_path { | ||
| files.insert(RAMDISK_FILE_NAME, ramdisk_path); | ||
| } |
Member
There was a problem hiding this comment.
Same as above (use if let and avoid the additional bindings in lines 151-154).
Comment on lines
+111
to
116
| pub fn with_ramdisk(&self, ramdisk_path: &Path) -> Self { | ||
| Self { | ||
| kernel: self.kernel.clone(), | ||
| ramdisk: Some(ramdisk_path.to_owned()), | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Same as above: set_ramdisk(&mut self, ramdisk_path: &Path) -> &mut Self.
Member
Co-authored-by: Philipp Oppermann <[email protected]>
Co-authored-by: Philipp Oppermann <[email protected]>
jasoncouture
added a commit
to jasoncouture/bootloader
that referenced
this pull request
Jan 2, 2023
Co-authored-by: Philipp Oppermann <[email protected]>
jasoncouture
added a commit
to jasoncouture/bootloader
that referenced
this pull request
Jan 3, 2023
Co-authored-by: Philipp Oppermann <[email protected]>
This was referenced Jan 4, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for adding a ramdisk file to the disk image.
I will follow up in a future PR to add support for loading and passing this to the kernel in a future PR.