Closed
Conversation
This adds support for loading a ramdisk/initrd, and an API to add one to the boot image.
Merged
Contributor
Author
|
The changes for this PR start at commit 3f24dd4 |
jasoncouture
force-pushed
the
feature_test_macros
branch
from
8564ab7 to
975d451
Compare
This was referenced Jan 4, 2023
Contributor
Author
|
The windows test failed due to timeout, see #309 for a potential fix |
phil-opp
reviewed
Jan 5, 2023
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks a lot!
A few points:
- I don't think that we need to duplicate all the tests with and without ramdisk. A few ramdisk-specific tests should be enough, the other tests can use
None.- This should also allow us to simplify the
define_testmacro.
- This should also allow us to simplify the
- This PR does not really depend on the ramdisk PR, so we could already apply it on top of
main. We can of course also wait until #302 is merged and rebase this PR afterwards if you prefer. - Could you explain the problem with the LTO test in more detail? I'm not sure what's the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the second item in #305 by separating the various boot methods and ramdisk tests into separate tests.
It will also generate ramdisk tests, unless explicitly told not to.