Conversation
|
Looks great already, thanks a lot! The serial printing seems to work already on the CI, for example we see the bootloader output here: https://github.com/rust-osdev/bootloader/actions/runs/3846887378/jobs/6552698281#step:11:223 Just for information: I just restarted the Windows CI job manually in the hope of triggering the timeout issue e.g. seen in #304. I suspect that the cause of that timeout could be a panic in the bootloader, which this PR should make visible. |
|
Makes sense. I'll also block |
phil-opp
left a comment
There was a problem hiding this comment.
Looks very good! I only left some style comments.
|
I can't apply the changes proposed by @jasoncouture in the linked issue because it's very difficult to refactor BIOS stages due incompatibility problems of the used crates of the logger. So, I think that this PR is ready to merge. |
|
Thanks! |
Hello,
This PR improves the actual logging of the bootloader.
Tasks:
Closes #306
Thanks!