kernel image fields & zero out rbp#346
Merged
phil-opp merged 3 commits intorust-osdev:mainfrom Aug 14, 2023
Merged
Conversation
phil-opp
approved these changes
Mar 12, 2023
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR! Looks good overall, but we need to be more explicit about the different address spaces.
Member
|
There is some prior discussion about a similar change in #177. Back then I argued that might not want to guarantee that we keep the full kernel ELF file in physical memory and instead make it configurable. My original thought was that we might want to optimize the memory consumption. However, we haven't implemented such an optimization in the past two years, so I think I'm fine with merging this as-is now. |
devsnek
force-pushed
the
x/kernel-image-fields
branch
from
2d9ae8f to
3f34b07
Compare
Contributor
Author
|
@phil-opp is anything still remaining here? could it be merged? |
devsnek
force-pushed
the
x/kernel-image-fields
branch
from
3f34b07 to
a65533a
Compare
phil-opp
approved these changes
Aug 14, 2023
Member
|
Thanks for the adjustments! Looks good, sorry for the slow review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these changes stemmed from my efforts to add stack traces to my kernel
rbpbefore jumping into your actual code so that you know where to stop the stack trace