Update uefi dependency to v0.20#360
Merged
phil-opp merged 7 commits intorust-osdev:mainfrom Apr 13, 2023
Merged
Conversation
This was referenced Mar 27, 2023
Closed
phil-opp
reviewed
Apr 9, 2023
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks for the PR! The update uefi v0.20 looks good. I left some comments inline. Once they're resolved, we can merge this.
phil-opp
changed the title
uefi dependency to v0.20
Contributor
Author
Going to do this tonight (Pacific Daylight Time/UTC-7) — with family at the moment. |
kennystrawnmusic
added a commit
to kennystrawnmusic/cryptos
that referenced
this pull request
Apr 12, 2023
Contributor
Author
Alright, just implemented your suggested changes. Sorry it took longer than expected; been very busy lately. |
Closed
kennystrawnmusic
added a commit
to kennystrawnmusic/cryptos
that referenced
this pull request
Apr 15, 2023
…ootloader anymore
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version (0.18.0) of the UEFI crate that bootloader 0.11.3 depends on has code that throws a myriad of future incompatibility/deprecation warnings when compilation is attempted ― deprecation warnings that are highlighted in the rust-lang/rust#107457 tracking issue. I therefore created this pull request that both fixes the version of UEFI depended on (0.20 doesn't have the same problems) and bumps the version of bootloader to 0.11.4 to ensure that this fix gets published to crates.io immediately after it's implemented.