Fixed "jc fail" instructions not working properly and updated README.md#453
Merged
Freax13 merged 2 commits intorust-osdev:mainfrom Aug 25, 2024
Merged
Fixed "jc fail" instructions not working properly and updated README.md#453Freax13 merged 2 commits intorust-osdev:mainfrom
Freax13 merged 2 commits intorust-osdev:mainfrom
Conversation
Freax13
requested changes
Aug 25, 2024
Member
Freax13
left a comment
Freax13
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Good catch! The same bug exists in stage-2. Could you fix it there as well?
Contributor
Author
|
I addressed the recommended changes in this new commit. I can squash into one commit if you would like. |
Freax13
approved these changes
Aug 25, 2024
Member
Freax13
left a comment
Freax13
left a comment
There was a problem hiding this comment.
LGTM! Thanks again!
I can squash into one commit if you would like.
That's alright, I can also do that when merging the PR.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the times where "jc fail" asm instructions are called are not behaving as expected. They need to be "call fail" in order for the stack to be set up properly to print the fail character. This can be reproduced by changing the jc to jnc and running in qemu.
I added a label in the boot.s that just calls the rust "fail" function and it seems to work as expected now.
I also updated the readme and fixed some error codes that were not unique.