Closed
Conversation
Contributor
Author
|
Probably worth thinking about if/how this would integrate with the new iter package in the stdlib. |
samber
reviewed
Jun 28, 2024
Owner
samber
left a comment
samber
left a comment
There was a problem hiding this comment.
I'm considering a new "iter" subpackage.
samber/lo is widely used and upgrading to Go 1.22 seems rough.
I think we can keep the same naming for every helpers, but under samber/lo/iter.
WDYT ?
|
|
||
| // MapI transforms an iterator into an iterator of another type. | ||
| // Play: https://go.dev/play/p/TODO | ||
| func MapI[T any, R any](iter Iterator[T], iteratee func(item T, index int) R) Iterator[R] { |
Owner
There was a problem hiding this comment.
I agree, we should receive and return iterators.
vkhobor
reviewed
Jul 17, 2024
| type Iterator[V any] func(func(int, V) bool) | ||
|
|
||
| // ToIterator TODO | ||
| func ToIterator[V any](collection ...V) Iterator[V] { |
There was a problem hiding this comment.
ToIterator might already be implemented in the go standard library as slices.All.
As per this comment: gomoni/it#12 (comment)
5 tasks
Merged
Contributor
Author
|
Implemented in #672 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was surprised to see no mention of the upcoming range-over-func experimental feature in the issues/PR list. I haven't measured anything but in theory this feature could dramatically reduce slice allocations when composing "queries" over large collections since no intermediate slices need to be created.
Is there any interest in this? This POC PR demonstrates what iterator support might look like, including tests and examples. I went with an "I" suffix (to mirror the "F" convention) to differentiate the iterator functions from their
slice.gocounterparts.For example: