feat: implement option key (#529)#552
feat: implement option key (#529)#552camilamaia merged 1 commit intoscanapi:mainfrom uesleicarvalhoo:529
Conversation
There was a problem hiding this comment.
Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.
In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.
We hope to see you around!
|
@uesleicarvalhoo thanks for the PR ⭐ Two of the checks that are failing are:
This is the test that is failing that requires GET call to pokeapi to be under 0.5 sec. @camilamaia can this be due a flaky tests ? |
|
@astenstrasser @camilamaia the changes looks good to me. What do you folks think ? |
|
Hey @uesleicarvalhoo the PR is amazing! Thanks for it 🤩 I tested it locally and works like a charm. Only two small considerations:
BTW, I've created already an issue for the website to update our doc once this is merged and released :) |
|
Hi @camilamaia, thanks! 😁 I thought that all requests is to same serve, then was no sense enalbe verify to one and disable to another one, but maybe some scenarios it makes sense, i will be update it! |
|
@camilamaia is up to date, can you check it? |
|
@uesleicarvalhoo Congrats on your first merged PR! 🌟 Thank you very much! I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works. Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them. Welcome on board and once again, thank you! 🙇♀️ |
Description
Implement key
optionstorequestandendpointnodes for allow keywords in torequestperforming call.The avaliable keys are
timeoutandverify. If both has sameoptions,request nodeis priorized.Motivation behind this PR?
#529
What type of change is this?
Feature
Checklist
Issue
Closes #529