Add --insecure flag in curl based on request options#555
Add --insecure flag in curl based on request options#555camilamaia merged 2 commits intoscanapi:mainfrom
Conversation
Crocmagnon
force-pushed
the
verify-curl
branch
from
f80868f to
c6f40b7
Compare
|
I didn't find any tests covering curl generation, so I wasn't sure where to start or whether they were necessary. Please advise :) I've updated some tests though. |
Crocmagnon
force-pushed
the
verify-curl
branch
from
c6f40b7 to
dd66d6b
Compare
![github-actions[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.
In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.
We hope to see you around!
github-actions
bot
added
the
First Contribution
Crocmagnon
force-pushed
the
verify-curl
branch
from
dd66d6b to
e9fc7cd
Compare
camilamaia
left a comment
camilamaia
left a comment
There was a problem hiding this comment.
@Crocmagnon, great catch and thanks for the fix!
Indeed, we don't have tests for the template yet, so the ones you added are enough for now. 👍
|
@Crocmagnon Congrats on your first PR merged! 🌟 Thank you very much! I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works. Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them. Welcome on board and once again, thank you! 🙇♀️ |
2 participants
Description
Add the
--insecureflag in curl based on request optionsMotivation behind this PR?
Closes #554
What type of change is this?
Bug fix
Checklist
Issue
Closes #554