Skip to content

chore(deps): remove gitlint#685

Merged
camilamaia merged 2 commits intomainfrom
680-2
Oct 11, 2024
Merged

chore(deps): remove gitlint#685
camilamaia merged 2 commits intomainfrom
680-2

Conversation

@antoniamaia
Copy link
Member

@antoniamaia antoniamaia commented Oct 11, 2024 •
edited
Loading

Description

gitlintis not being maintained anymore, we removed it.

Motivation behind this PR?

This was happening:

ERROR: Cannot install -r requirements.txt (line 1) and -r requirements.txt (line 5) because these package versions have conflicting dependencies.

The conflict is caused by:
    flask 3.0.3 depends on click>=8.1.3
    scanapi 2.10.0 depends on click==8.0.3

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

What type of change is this?

Removing dead dependencies

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #680

@antoniamaia antoniamaia requested review from a team as code owners October 11, 2024 20:42
@codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (926b43e) to head (622163f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          24       24           
  Lines         784      784           
=======================================
  Hits          768      768           
  Misses         16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions[bot]
github-actions bot reviewed Oct 11, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@github-actions github-actions bot added the First Contribution First contribution to the project. label Oct 11, 2024
camilamaia
camilamaia approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning of an era

@camilamaia camilamaia merged commit 5704b75 into main Oct 11, 2024
@camilamaia camilamaia deleted the 680-2 branch October 11, 2024 20:53
@antoniamaia antoniamaia mentioned this pull request Oct 11, 2024
Merged
@taconi taconi mentioned this pull request Oct 11, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

First Contribution First contribution to the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Click

2 participants

@antoniamaia @camilamaia