Merged
Conversation
When running discovery multiple times, duplicate Docker bridge interfaces
and empty host entries were created instead of conflating with existing
entities.
Root causes:
- Interface equality only compared IP + subnet_id, so containers with
changed IPs (Docker DHCP) were treated as new interfaces
- Docker discovery didn't include the daemon host's physical interfaces,
so network discovery couldn't match hosts by MAC or subnet+IP
Changes:
- Add MAC address to Interface PartialEq and Hash implementations
- Include daemon host physical interfaces in Docker discovery temp host
When running discovery multiple times, duplicate Docker bridge interfaces
and empty host entries were created instead of conflating with existing
entities.
Root causes:
- Interface equality only compared IP + subnet_id, so containers with
changed IPs (Docker DHCP) were treated as new interfaces
- Docker discovery didn't include the daemon host's physical interfaces,
so network discovery couldn't match hosts by MAC or subnet+IP
Changes:
- Add MAC address to Interface PartialEq and Hash implementations
- Include daemon host physical interfaces in Docker discovery temp host
…ap prevention
Add horizontal compression pass that runs after edge optimization:
- Subnets with non-horizontal (vertical/mixed) edges are locked in place
- Unlocked subnets are compressed toward locked ones to minimize empty space
- Subnets with no locked neighbors compress toward the left edge
Fix subnet overlap bug in apply_non_overlap_constraint:
- Previous logic could oscillate between positions when multiple subnets
wanted the same X coordinate (e.g., docker bridges connecting to same host)
- New approach generates candidate positions at subnet edges and selects
the valid non-overlapping position closest to the optimal edge length
Add SUBNET_PADDING constant (125px) for consistent spacing throughout
the subnet positioning algorithm.
- Fix auto reload toggle not persisting across page reloads by adding
localStorage save/load logic and preventing initial subscription from
overwriting stored value
- Align backend default for group_docker_bridges_by_host to true,
matching the frontend default
- Hide interface edge labels when both connected nodes are on the same
subnet to reduce visual clutter
…s an equality key
…s an equality key
…s an equality key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.