Merged
Conversation
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback Would you like me to run the actual commit with this message?
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback Would you like me to run the actual commit with this message?
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback
Replace the legacy Visualizer permission workaround with a proper sharing system that supports password-protected links and embeddable iframes. Share Features: - Create shareable links with optional password protection - Generate embeddable iframes with domain restrictions - Configure visibility of zoom controls and inspect panel per share - Set expiration dates and enable/disable shares - Password persistence via sessionStorage for seamless page refreshes - Showcase option linking to community gallery submission form Public Share Pages: - /share/[id] - Full-page view with header and export button - /share/[id]/embed - Minimal chrome for iframe embedding - PasswordGate modal using EditModal pattern for consistency - ReadOnlyTopologyViewer with inspector panel support via context Permission Model Changes: - Remove None permission level entirely - Rename Visualizer to Viewer (with serde alias for compatibility) - All users now count towards seat limits (remove counts_towards_seats) - Only Admin+ can invite users (Members can no longer invite) - Migration converts existing Visualizer/None permissions to Viewer Backend: - New shares module with CRUD handlers and public access endpoints - Password hashing with Argon2 (reuses auth service) - Share validation (expiration, enabled status, domain restrictions) - ShareWithTopology response includes topology data after auth Frontend: - ShareModal with type selector (Link/Embed/Showcase) - ShareTab for managing shares per topology - BaseTopologyViewer extracted for code reuse - Inspector components use context with store fallback
…into feat/topo-share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.