fix: resolve network scan hangs and subnet misclassification on Unraid#381
Merged
fix: resolve network scan hangs and subnet misclassification on Unraid#381
Conversation
This addresses two issues affecting network discovery reliability: 1. ARP Scan Hang (#374): Network scans hung indefinitely when targets didn't respond to ARP requests. The datalink channel was using default config with no read_timeout, causing rx.next() to block forever. Added 100ms read_timeout to allow deadline checks. 2. Subnet Misclassification (#374): On Unraid/Proxmox systems where the physical LAN uses a bridge interface (br0), subnets were incorrectly classified as DockerBridge, causing network discovery to skip them. Root cause: Docker's macvlan/ipvlan networks (used for container LAN access) were being treated the same as bridge networks, and the filter logic was backwards - removing host subnets instead of Docker subnets when CIDRs overlapped. Fixes: - Filter Docker networks by driver type: only bridge/overlay are DockerBridge, skip macvlan/ipvlan/host - Flip filter precedence: host interfaces take priority over Docker networks with same CIDR - Add br to LAN interface patterns (distinct from br- which is Docker's convention)
mayanayza
added a commit
that referenced
this pull request
Feb 24, 2026
fix: resolve network scan hangs and subnet misclassification on Unraid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two issues affecting network discovery reliability:
ARP Scan Hang (Network scan not working docker on unraid. #374): Network scans hung indefinitely when targets didn't respond to ARP requests. The datalink channel was using default config with no read_timeout, causing rx.next() to block forever. Added 100ms read_timeout to allow deadline checks.
Subnet Misclassification (Network scan not working docker on unraid. #374): On Unraid/Proxmox systems where the physical LAN uses a bridge interface (br0), subnets were incorrectly classified as DockerBridge, causing network discovery to skip them.
Root cause: Docker's macvlan/ipvlan networks (used for container LAN access) were being treated the same as bridge networks, and the filter logic was backwards - removing host subnets instead of Docker subnets when CIDRs overlapped.
Fixes: - Filter Docker networks by driver type: only bridge/overlay are DockerBridge, skip macvlan/ipvlan/host - Flip filter precedence: host interfaces take priority over Docker networks with same CIDR - Add br to LAN interface patterns (distinct from br- which is Docker's convention)