Skip to content

Collect scene nodes recursively#224

Merged
schell merged 8 commits intomainfrom
collect_scene_nodes_recursively
Mar 21, 2026
Merged

Collect scene nodes recursively#224
schell merged 8 commits intomainfrom
collect_scene_nodes_recursively

Conversation

@schell
Copy link
Owner

@schell schell commented Mar 18, 2026

Addresses PR comments on #217 .

Closes #217

@schell schell marked this pull request as ready for review March 18, 2026 18:31
@schell schell force-pushed the collect_scene_nodes_recursively branch from f955efb to a53ba23 Compare March 18, 2026 22:33
m0ppers and others added 2 commits March 21, 2026 10:29
…scene

Split the scene node query API into two explicit methods:

- root_nodes_in_scene: returns only the top-level nodes directly
  referenced by the scene (the original behavior)
- recursive_nodes_in_scene: returns all nodes including descendants
  in depth-first order

This fixes a bug where animations targeting child (parented) nodes
were silently skipped because only root nodes were collected.

Update call sites:
- Animator test now uses recursive_nodes_in_scene for correctness
- Example crate simplified by removing manual get_children helper

Co-authored-by: Andreas Streichardt <[email protected]>
@schell schell force-pushed the collect_scene_nodes_recursively branch from 3675d04 to 79c3d96 Compare March 20, 2026 21:29
@schell schell force-pushed the collect_scene_nodes_recursively branch from 9065b87 to 8aba870 Compare March 21, 2026 01:34
@schell schell merged commit 7d668ed into main Mar 21, 2026
11 checks passed
@schell schell deleted the collect_scene_nodes_recursively branch March 21, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants