Change redundant 'text' entry to 'name' in ld+json example for Question#1799
Merged
chaals merged 1 commit intoschemaorg:masterfrom Nov 21, 2017
fisxoj:fix-question-example
Merged
Change redundant 'text' entry to 'name' in ld+json example for Question#1799chaals merged 1 commit intoschemaorg:masterfrom fisxoj:fix-question-example
chaals merged 1 commit intoschemaorg:masterfrom
fisxoj:fix-question-example
Conversation
fisxoj
changed the title
fisxoj
changed the title
Contributor
|
Yes, spot on. Thank you! |
|
This is a landmark PR. Thank you for all your hard work!! |
Contributor
|
Note that errors like this are actually detected in Travis-CI: https://travis-ci.org/schemaorg/schemaorg, although these have only been in as unexamined warnings for some time, due to the volume of examples having semantic or syntactic problems (most of the syntactic problems have been found, at least). The idea would be to eventually make errors fail CI, which would prevent a PR from being merged until corrected, and thus not introduce new example errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I did a quick look around for contribution guidelines, and hopefully this is simple enough not to be too much trouble, regardless.
The example for
Questionhad the fieldtexttwice. I believe the first entry is supposed to bename, based on the other examples for the same item.