Fixed all RDF comments that did not finish with a punctuation.#3349
Merged
RichardWallis merged 1 commit intoschemaorg:mainfrom Jul 19, 2023
Merged
Fixed all RDF comments that did not finish with a punctuation.#3349RichardWallis merged 1 commit intoschemaorg:mainfrom
RichardWallis merged 1 commit intoschemaorg:mainfrom
Conversation
Contributor
MatthiasWiesmann
commented
Jul 14, 2023
MatthiasWiesmann
commented
- Relaxed the validation logic to accept question marks and closing parenthesis.
- Made test a real, i.e. it does not expect to fail.
- Improved the error reporting so from a failure you know which term violate the rule.
- Added test comment/documentation for nicer display in the test output.
* Relaxed the validation logic to accept question marks and closing parenthesis. * Made test a real, i.e. it does not expect to fail. * Improved the error reporting so from a failure you know which term violate the rule. * Added test comment/documentation for nicer display in the test output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.