Skip to content

Move Fibo.schema.org proposal in to pending#1300

Merged
danbri merged 15 commits intoschemaorg:sdo-callistofrom
edmcouncil:fibo-ext-1.0
Oct 10, 2016
Merged

Move Fibo.schema.org proposal in to pending#1300
danbri merged 15 commits intoschemaorg:sdo-callistofrom
edmcouncil:fibo-ext-1.0

Conversation

@RichardWallis
Copy link
Contributor

Replaces PR (#1254) (merge into sdo-makemake)

@RichardWallis
Copy link
Contributor Author

See conversations on PR (#1254) & Issue (#1253)
This is an update to the original proposal PR (#1163) - A Pull Request constituting a proposal for a FIBO extension to Schema.org from the Financial Industry Business Ontology Community Group.

Changes from original:

@RichardWallis RichardWallis mentioned this pull request Aug 12, 2016
24 tasks
@rvguha
Copy link
Contributor

rvguha commented Sep 30, 2016

The schema changes look good.

Examples: Lets use fictitious entities in our examples.

@RichardWallis
Copy link
Contributor Author

No problem on the fictional examples.

Will update these in next couple of days and also resolve the merge conflict.

@danbri
Copy link
Contributor

danbri commented Sep 30, 2016

My review notes:

  • PR includes a needless (and conflicting) sdoapp.py edit - can you remove that please?
  • let's put this into pending.schema.org first, with a view to moving it along towards a hosted extension subdomain a release or two after that.
  • I would prefer its eventual home to be under something like "finance.schema.org". We have merged in contributions from BBC, EBU, MusicBrainz, GoodRelations, GS1 and many others in previous releases without creating a project-or-collaboration-acronym-based subdomain. I appreciate the desire for fibo.schema.org but I suggest it is better to keep collaboration and derivation acknowledgments elsewhere (in human-facing text and in machine definitions, but not in subdomains).

@sopekmir
Copy link
Contributor

sopekmir commented Oct 6, 2016

Hi Dan,
Sorry for late reply. We will remove the edit and we are also making our examples fictional (after Guha's request).
As for placing it into pending - that's great and this is exactly what we expected to happen. Thanks !

When it comes to the change to the name of the extension, I hope it will not be a problem for the other members of the community which brought the concept of the extension to life. I will start my consultations asap.

@sopekmir
Copy link
Contributor

sopekmir commented Oct 6, 2016

BTW, I just got info from Richard that the requested changes has been made! Thanks Richard !

@Dataliberate
Copy link
Contributor

Now issues raised by Guha have been addressed, can we merge this now.

Copy link
Contributor

@danbri danbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbri danbri merged commit dbf195c into schemaorg:sdo-callisto Oct 10, 2016
@danbri danbri mentioned this pull request Sep 27, 2017
@trypuz
Copy link
Contributor

trypuz commented Sep 27, 2017

@danbri, @RichardWallis, what is the next step? Is there anything FIBO community can do to move the FIBO extension from "pending" towards a hosted extension?

@sopekmir
Copy link
Contributor

I'm aware about reservations to move the extension to the one named by "fibo". Indeed, living between the two worlds, I must admit we had long lasting difficulties with the FIBO team to give us proper, canonical FIBO URIs, so that we could amend the extension documentation and have a "hard link" between the extension and the ontology. However, as it is more problematic for teh extension to stay in "pending" for so long, than having a permanent name, maybe we would indeed go for finance.schema.org for the upcoming edition? Is it possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants