Closed
Conversation
Contributor
|
These changes look good to me. Are they able to be reviewed / merged? |
Contributor
|
Hi both. I didn't fold these into 3.3 as it was already signed off by the steering group, but both seem reasonable changes. In retrospect I probably should've done step/steps at least. For "text", another approach would be to add CreativeWork as a(n extra) supertype of HowToDirection and HowToTip which would give us the "text" property and others for free, without special casing "text" for howtos. I lean towards that design. @vholland, any thoughts? |
Contributor
|
Making CreativeWork a supertype makes sense to me. |
Contributor
Author
|
OK, this is made obsolete by #1729. |
|
Do you guys have an example or sample code I could view for AI? |
Contributor
Author
|
I don't follow. Can you elaborate on what you're looking for?
On Wed, Aug 30, 2017 at 4:37 AM Mindy Shaw ***@***.***> wrote:
Do you guys have an example or sample code I could view for AI?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1707 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzSEBzPiv7wAy49HW1lKIZP8XktGuKeks5sdS1RgaJpZM4OmDrh>
.
--
From the personal email account of Earl J. Wagner at [email protected]
Please note: My incoming email is filtered into folders and I may not see
your email for several days.
Emails from accounts that send mass emails are filtered to a folder checked
about once per month.
If you'd like a faster response, text me a brief message on my cell at
773-960-1809
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "text" property for step text in HowToDirection and HowToTip.
Renames property to "step", allowing multiple steps to be specified.