Conversation
- This makes all children (itemListElement field) of HowToSection be of type HowToStep. Effectively wraps any HowToDirection that was previously a child of HowToSection. My understanding of the design is HowToDirection & HowToTip should only be found inside a HowToStep. - Added "position" attribute to all instances of itemListElement - Fixed the "...Media" properties of HowToDirection in Microdata example
|
@danbri @RichardWallis - some more fixes for the HowTo samples. Mind taking a look? |
|
@danbri The structure looks fine. I share your questioning thoughts about the media attributes. They are defined as expecting MediaObject. What is shown in the example are defaulting to URL, which is OK, but not very representative of what might be expected. There again, MediaObject is probably a bit heavyweight in many real world situations, where for example a link to a YouTube video could be expected. Perhaps adding URL to the expected type for these properties may clarify things for simplistic situations whilst not loosing the potential descriptive power of being able to use MediaObject. |
Noticed that <img> was using "href" by mistake - changed to "src" for the URL. Moved the before/after/during-Media properties into the same HowTo section so it's a bit easier to read. Update the MediaObject usage - now all 3 examples use the "url" property. (Verified in Google Structured Testing Tool)
|
Here's an update with using MediaObject - url - property (previously it was using the name, at least in Google SDTT). Note that for Microdata, I didn't have to create a wrapper div, though I did for RDFa. I'm gonna follow up with a change to contentUrl in this pull request. I do like the idea of supporting URL for the media properties. Do we want to do that in this release? If so, perhaps a followup pull request after this one? One thing comes to mind is that with MediaObject, providers could use the subtypes ImageObject or VideoObject which give semantics about what kind of media it is. |
|
@dbiollo Thanks for your efforts here. By default URL is supported as a value for these properties (in fact the value for any property can be a Text, URL, or Role). I would be in favour of explicitly stating this to help understanding in this area. As it is simple to do, I suggest we could do it in the upcoming release with this PR. @danbri what are your thoughts? |
Note that the duringMedia example (<img src="proxy.php?url=position-jack.mp4" />) is an image with a video link, so I've left it as a MediaObject. Having a good video example may be useful.
|
SGTM, go for it!
…On Wed, 16 May 2018, 13:48 Richard Wallis, ***@***.***> wrote:
@dbiollo <https://github.com/dbiollo> Thanks for your efforts here.
By default URL is supported as a value for these properties (in fact the
value for any property can be a Text, URL, or Role
<http://schema.org/docs/datamodel.html#conformance>). I would be in
favour of explicitly stating this to help understanding in this area.
As it is simple to do, I suggest we could do it in the upcoming release
with this PR.
@danbri <https://github.com/danbri> what are your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1919 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKZGV_dEZllRAXEAVw5PuNV9ZXjLvwjks5tzBIdgaJpZM4T-Mpc>
.
|
Explicitly show URL in range of HowToDirection . beforeMedia, afterMe…
|
I've added the Docs for URL, and changed the "duringMedia" example to be just a URL. Please have a look and make sure this is what you meant. I tested this in Google Structured Data TT and it doesn't seem to recognize the media attributes as URL. Maybe this is b/c the Range change hasn't been published? Not sure if there will be issues or if this will be OK once the schema gets released? |
|
From looking at the sources this looks OK. Probably needs a final look over once it is merged and put up on Webschemas.org. Yes, the lack of recognition of URL as an expected type in the SDTT, and other testing tools, will be because it does not get updated until after a new release. |
|
Merged, I'll get it onto webschemas.org for final tire-kicking tomorrow... Thanks! |
|
Thanks Dan! Looking forward to trying out the updated webschemas.org! |
|
done - http://webschemas.org/HowTo and nearby ought to be same as github master branch now |
Neglected to propagate img tag changes to the the html sample in schemaorg#1919
|
Uh-oh, the attributes table is missing from http://webschemas.org/HowTo ... |
|
I’ll take a look. |
|
Fixed now |
|
Thanks, looks good now! |
* Small fix to howto html samples Neglected to propagate img tag changes to the the html sample in #1919 * Reduced indenting to consistent 2 spaces Was pretty hard to read with the bigger font in webschemas.org. This reduces indenting to 2 chars
* 'master' of https://github.com/schemaorg/schemaorg: (76 commits) Added tests for correct operation of traverseForHTML & traverseForJSONLD functions Updated for contentRating / Rating tweak. Added Rating as expected of contentRating, for schemaorg#1935 Thanks @vholland! Noted alias of HTML from rdf:HTML, schemaorg#1634 alias HTML to rdf:HTML (schemaorg#1634) Obvious 404 fixes from issue (schemaorg#1901) (schemaorg#1930) Changes to move to https only (for UI, not for vocab URIs) (schemaorg#1932) Fix to docs/tree.jsonld causing crash 2018 -> 2017, fixes schemaorg#1929 Thanks @Aaranged :) Removed duplicate entries, and added a summary. schemaorg#1891 Updated to cover all changes in 3.4. More release notes. Added lots of release notes, converted from git. Update releases.html One-liner for creating release note entries. Working on conversion of 900+ lines of changes into release note format. For schemaorg#1891 release 3.4. Tweaks to image tag, changed "mp4" to "jpg", added alt. /cc schemaorg#1922 Small fix to howto html samples (schemaorg#1922) Fixes for the HowTo sample (schemaorg#1919) Fix physician subclass (schemaorg#1911) ... # Conflicts: # app.yaml
3 participants
This seems to fix issues found in Google Structured Data Testing Tool, though not 100% certain about the validity of the before/during/after-Media attributes.