Skip to content

Rationalised enumeration definitions#2250

Merged
danbri merged 4 commits intomasterfrom
EnumParents
Jan 2, 2020
Merged

Rationalised enumeration definitions#2250
danbri merged 4 commits intomasterfrom
EnumParents

Conversation

@RichardWallis
Copy link
Contributor

Investigation of issue #2236 identified inconsistencies in the way enumerations and their members have been defined and sub-typed.

This PR rationalises them and adds tests to identify future issues.

@RichardWallis
Copy link
Contributor Author

RichardWallis commented Oct 30, 2019

Rationalisation in this PR applies the following logic to enumerations and their values:

  • An Enumeration is defined as type rdfs:Class and rdfs:subClassOf of http://schema.org/Enumeration
  • An enumeration value is not defined as type rdfs:Class but is defined as type a valid Enumeration

Also includes unit test to identify wrongly defined enumeration & enumeration values.

@RichardWallis
Copy link
Contributor Author

Snippet for Site Improvements section of releases.html:

<li id="2236"><a href="proxy.php?url=https://github.com/schemaorg/schemaorg/issues/2236">Issue #2236</a>:
(implemented in <a href="proxy.php?url=https://github.com/schemaorg/schemaorg/pull/2250">PR #2250</a>):
Rationalised definitions for enumeration values so they are consistent.  Added tests to confim consistency.
</li>

@danbri danbri merged commit e5003bd into master Jan 2, 2020
@danbri
Copy link
Contributor

danbri commented Jan 22, 2020

This has been reverted; discussion in the issue.

See also #2443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants