Skip to content

Example fixes#260

Merged
danbri merged 12 commits intoschemaorg:sdo-stantzfrom
gkellogg:example-fixes
Jan 22, 2015
Merged

Example fixes#260
danbri merged 12 commits intoschemaorg:sdo-stantzfrom
gkellogg:example-fixes

Conversation

@danbri
Copy link
Contributor

@danbri danbri commented Jan 22, 2015

This is #199 but directed at sdo-stantz.

@gkellogg
Fix seriously broken URL in games-6 example. (This actually caused my…
b6679a5 
… URI validation regexp to hang!)
@gkellogg
Broken RDFa markup on games-1 caused cheat to be associated with Vide…
db569fc 
…oObject, not VideoGame.
@gkellogg
Wrong property usage in game-3.
dd98962
@gkellogg
Games-6 minAge doesn't parse as Number due to added space, which is u…
9d3cb7d 
…nnecessary in markup.
@gkellogg
music-2 example used "type" instead of "@type".
29ee5c2
@gkellogg
music-3 example used obsolete namedPosition instead of roleName.
0d16009
@gkellogg
music-5 used releaseEvent instead of releasedEvent. Perhaps the prope…
8624f7f 
…rty is misnamed?
@gkellogg
bib-5 microdata and RDFa should use @datetime property instead of @co…
e2f9949 
…ntent to properly parse the Duration value.
@gkellogg
Bad date format in games-7 example. Also, note that gameLocation is n…
1453f10 
…ot a property of VideoGameSeries.
@gkellogg
Book example had "598 Pages" as the value of numberOfPages. Moved 598…
12178d3 
… to a span and removed " Pages" from JSON-LD.
@gkellogg
BusReservation example used undefined "operatingCompany" instead of "…
1dcb39e 
…provider..
@gkellogg
BuyAction example used "location" with Amazon as a "Product". Changed…
d861569 
… to "seller" and "Organization".
@danbri danbri added guidelines docs examples Work on our supporting materials rather than on schema definitions type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc type:bug A mistake or malfunction whose remedy should be straightforward technical work and removed type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc labels Jan 22, 2015
danbri added a commit that referenced this pull request Jan 22, 2015
@danbri
Merge pull request #260 from gkellogg/example-fixes
6211ef0 
Example fixes from @gkellogg  - thanks!
@danbri danbri merged commit 6211ef0 into schemaorg:sdo-stantz Jan 22, 2015
@danbri danbri mentioned this pull request Jan 22, 2015
Closed
scor
scor reviewed Jan 22, 2015
View reviewed changes
data/sdo-videogame-examples.txt
Copy link
Contributor

@scor scor Jan 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%20, not just %

@gkellogg gkellogg deleted the example-fixes branch April 11, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

guidelines docs examples Work on our supporting materials rather than on schema definitions type:bug A mistake or malfunction whose remedy should be straightforward technical work type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danbri @scor @elf-pavlik @gkellogg