issue 2658: Supertype of Question should be Comment#2662
Merged
danbri merged 9 commits intoschemaorg:mainfrom Jul 23, 2020
Merged
issue 2658: Supertype of Question should be Comment#2662danbri merged 9 commits intoschemaorg:mainfrom
danbri merged 9 commits intoschemaorg:mainfrom
Conversation
update to merge with schema.org
merge master changes into fork
merge updates from master
merge master from schema.org
update fork
merge from master
Supertype of question should be comment
revert release file
Change supertype of Question to Comment
Contributor
|
LGTM |
|
Should we also remove downvoteCount and upvoteCount from Question directly, now that it will get these properties from Comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supertype of Question should be Comment, so as to be on the same ontological level as Answer (which is currently nested under Comment).