Update version of RDF gem to 3.1.6.#2697
Merged
RichardWallis merged 2 commits intoschemaorg:v11from Sep 7, 2020
Merged
Conversation
Contributor
|
Thanks for this Greg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problem creating script/spec/schema.rb.
@Dataliberate Note that the Travis stage has never passed cleanly, but the results are ignored so as not to impede other work; this has been the case for several years now. Currently, Travis is showing of 8544 example tests, 67 fail with issues, most of which seem like legitimate markup or semantic issues to me. If a push could be made to clean these up, this stage could be allowed to fail, which would help prevent future errors from being introduced, which was the whole point of adding the linting pass.
Random examples:
property schema:dateCreated
Object "1971-1972"^^http://schema.org/Date not compatible with rangeIncludes (schema:Date,schema:DateTime)
property schema:summaryUrl
No property definition found
...
Failed to parse input document: loading document failed: 434: unexpected token at ...
If there are some things you think the linter shouldn't be flagging, let's discuss.