Skip to content

Update version of RDF gem to 3.1.6.#2697

Merged
RichardWallis merged 2 commits intoschemaorg:v11from
gkellogg:v11
Sep 7, 2020
Merged

Update version of RDF gem to 3.1.6.#2697
RichardWallis merged 2 commits intoschemaorg:v11from
gkellogg:v11

Conversation

@gkellogg
Copy link
Contributor

@gkellogg gkellogg commented Sep 5, 2020

Fixes problem creating script/spec/schema.rb.

@Dataliberate Note that the Travis stage has never passed cleanly, but the results are ignored so as not to impede other work; this has been the case for several years now. Currently, Travis is showing of 8544 example tests, 67 fail with issues, most of which seem like legitimate markup or semantic issues to me. If a push could be made to clean these up, this stage could be allowed to fail, which would help prevent future errors from being introduced, which was the whole point of adding the linting pass.

Random examples:

  • Examples issue-1758-examples.txt[255] - ArchiveComponent-457 (jsonld)
    property schema:dateCreated
    Object "1971-1972"^^http://schema.org/Date not compatible with rangeIncludes (schema:Date,schema:DateTime)
  • issue-1062-examples.txt[17] - HealthInsurancePlan-PreferredNetwork-NonPreferredNetwork. HealthPlanFormulary-HealthPlanCostSharingSpecification-428 (jsonld)
    property schema:summaryUrl
    No property definition found
    ...
  • Examples issue-2405-examples.txt[286] - Recommendation-414 (jsonld)
    Failed to parse input document: loading document failed: 434: unexpected token at ...

If there are some things you think the linter shouldn't be flagging, let's discuss.

@RichardWallis
Copy link
Contributor

Thanks for this Greg

@RichardWallis RichardWallis merged commit 0f31600 into schemaorg:v11 Sep 7, 2020
@gkellogg gkellogg deleted the v11 branch September 10, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants