Conversation
alex-jansen
changed the title
danbri
requested changes
Dec 14, 2021
Contributor
danbri
left a comment
danbri
left a comment
There was a problem hiding this comment.
Can we call this iso6523Id or similar?
|
I would name it iso6523Code to be consistent with leiCode. |
Contributor
|
Sgtm - I have merged it and will make the changes I suggested
…On Tue, 14 Dec 2021 at 10:14, Matthias Wiesmann ***@***.***> wrote:
I would name it iso6523Code to be consistent with leiCode.
The attributes with the 'id' suffix are more generic (taxID, vatID).
The 'naics' attribute has no suffix.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3008 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJSGMD5OCQ7D3GUUTNBGTUQ4KKDANCNFSM5JPKDIFA>
.
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.