Conversation
Contributor
|
@alex-jansen it looks like there are some mistakes in the examples markup. Extracted from the giant failed build log: Let's look at one of them, the second: First, here are the triples as parsed by the JSON-LD Playground (to make some it's not something at the syntax level, weirdness around context processing, use '@' in the rdf:type property shorthand, etc. |
Contributor
|
I think the issue is the list of contexts includes the verifiable credentials context after Schema.org's, and so we give it a chance to have the last word grabbing short names for any terms it likes. And apparently 'name' is claimed there, overwriting schema.org's 'name'. I think that explains these three, although when we look at that context definition from VC W3C definition it seems to use 'name' purely as shorthand for schema.org 'name'.
Note 'schemas' rather than 'schema'. I don't know how JSON-LD chose that short name for the verifiable credentials ns. Here is some of their JSON-LD context: This one (which appears in (1.) also) seems simpler:
Does a Certification have a logo? should it? Do we try to say that anywhere? Let's figure out the 'name' stuff first! /cc @MatthiasWiesmann @alex-jansen @RichardWallis @msporny @philarcher |
Contributor
I tried pasting it into the validator manually and get But if the schema.org tests know 'name' is defined in the VC context then it must be loading it, ... so I don't think that's the issue. Ideas? |
Contributor
Author
|
2 errors fixed (logo and example numbering), but the schemas:name issue is
puzzling...
…On Mon, Jan 15, 2024 at 1:09 PM Dan Brickley ***@***.***> wrote:
I think the issue is the list of contexts includes the verifiable
credentials context *after* Schema.org's, and so we give it a chance to
have the last word grabbing short names for any terms it likes. And
apparently 'name' is claimed there, overwriting schema.org's 'name'. I
think that explains these three, although when we look at that context
definition from VC W3C definition it seems to use 'name' purely as
shorthand for schema.org 'name'.
- property schemas:name
-
Subject _:g297020(schema:Certification) not compatible with domainIncludes (schemas:Thing)
- Subject _:g297040(schema:Organization) not compatible with
domainIncludes (schemas:Thing)
- Subject _:g297060(schema:QuantitativeValue) not compatible with
domainIncludes (schemas:Thing)
Note 'schemas' rather than 'schema'. I don't know how JSON-LD chose that
short name for the verifiable credentials ns.
Here is some of their JSON-LD context:
[...]
"description": "https://schema.org/description",
"name": "https://schema.org/name",
"EnvelopedVerifiableCredential":
"https://www.w3.org/2018/credentials#EnvelopedVerifiableCredential",
"VerifiableCredential": {
***@***.***": "https://www.w3.org/2018/credentials#VerifiableCredential",
***@***.***": {
***@***.***": true,
"id": ***@***.***",
"type": ***@***.***",
"credentialSchema": {
***@***.***": "https://www.w3.org/2018/credentials#credentialSchema",
***@***.***": ***@***.***"
},
"credentialStatus": {
***@***.***": "https://www.w3.org/2018/credentials#credentialStatus",
***@***.***": ***@***.***"
},
"credentialSubject": {
***@***.***": "https://www.w3.org/2018/credentials#credentialSubject",
***@***.***": ***@***.***"
},
"description": "https://schema.org/description",
"evidence": {
***@***.***": "https://www.w3.org/2018/credentials#evidence",
***@***.***": ***@***.***"
},
"validFrom": {
***@***.***": "https://www.w3.org/2018/credentials#validFrom",
***@***.***": "http://www.w3.org/2001/XMLSchema#dateTime"
},
"validUntil": {
***@***.***": "https://www.w3.org/2018/credentials#validUntil",
***@***.***": "http://www.w3.org/2001/XMLSchema#dateTime"
},
"issuer": {
***@***.***": "https://www.w3.org/2018/credentials#issuer",
***@***.***": ***@***.***"
},
"name": "https://schema.org/name",
....
This one (which appears in (1.) also) seems simpler:
- property schema:logo
* Subject _:g297020(schema:Certification) not compatible with
domainIncludes
(schema:Brand,schema:Organization,schema:Place,schema:Product,schema:Service)
*Does a Certification have a logo? should it? Do we try to say that
anywhere?*
Let's figure out the 'name' stuff first!
/cc @MatthiasWiesmann <https://github.com/MatthiasWiesmann> @alex-jansen
<https://github.com/alex-jansen> @RichardWallis
<https://github.com/RichardWallis> @msporny <https://github.com/msporny>
@philarcher <https://github.com/philarcher>
—
Reply to this email directly, view it on GitHub
<#3441 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APYBL6ZJS5J4M2OX7YLHZRTYOUMAHAVCNFSM6AAAAABBOVAX3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGA2DQNRQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
replacing "name" with "schema:name" in the problematic examples fixes the
errors...
…On Mon, Jan 15, 2024 at 2:43 PM Alex Jansen ***@***.***> wrote:
2 errors fixed (logo and example numbering), but the schemas:name issue is
puzzling...
On Mon, Jan 15, 2024 at 1:09 PM Dan Brickley ***@***.***>
wrote:
> I think the issue is the list of contexts includes the verifiable
> credentials context *after* Schema.org's, and so we give it a chance to
> have the last word grabbing short names for any terms it likes. And
> apparently 'name' is claimed there, overwriting schema.org's 'name'. I
> think that explains these three, although when we look at that context
> definition from VC W3C definition it seems to use 'name' purely as
> shorthand for schema.org 'name'.
>
> - property schemas:name
> -
>
> Subject _:g297020(schema:Certification) not compatible with domainIncludes (schemas:Thing)
>
> - Subject _:g297040(schema:Organization) not compatible with
> domainIncludes (schemas:Thing)
> - Subject _:g297060(schema:QuantitativeValue) not compatible with
> domainIncludes (schemas:Thing)
>
> Note 'schemas' rather than 'schema'. I don't know how JSON-LD chose that
> short name for the verifiable credentials ns.
>
> Here is some of their JSON-LD context:
>
> [...]
> "description": "https://schema.org/description",
> "name": "https://schema.org/name",
>
> "EnvelopedVerifiableCredential":
> "https://www.w3.org/2018/credentials#EnvelopedVerifiableCredential",
>
> "VerifiableCredential": {
> ***@***.***": "https://www.w3.org/2018/credentials#VerifiableCredential",
> ***@***.***": {
> ***@***.***": true,
>
> "id": ***@***.***",
> "type": ***@***.***",
>
> "credentialSchema": {
> ***@***.***": "https://www.w3.org/2018/credentials#credentialSchema",
> ***@***.***": ***@***.***"
> },
> "credentialStatus": {
> ***@***.***": "https://www.w3.org/2018/credentials#credentialStatus",
> ***@***.***": ***@***.***"
> },
> "credentialSubject": {
> ***@***.***": "https://www.w3.org/2018/credentials#credentialSubject",
> ***@***.***": ***@***.***"
> },
> "description": "https://schema.org/description",
> "evidence": {
> ***@***.***": "https://www.w3.org/2018/credentials#evidence",
> ***@***.***": ***@***.***"
> },
> "validFrom": {
> ***@***.***": "https://www.w3.org/2018/credentials#validFrom",
> ***@***.***": "http://www.w3.org/2001/XMLSchema#dateTime"
> },
> "validUntil": {
> ***@***.***": "https://www.w3.org/2018/credentials#validUntil",
> ***@***.***": "http://www.w3.org/2001/XMLSchema#dateTime"
> },
> "issuer": {
> ***@***.***": "https://www.w3.org/2018/credentials#issuer",
> ***@***.***": ***@***.***"
> },
> "name": "https://schema.org/name",
> ....
>
> This one (which appears in (1.) also) seems simpler:
>
> - property schema:logo
> * Subject _:g297020(schema:Certification) not compatible with
> domainIncludes
> (schema:Brand,schema:Organization,schema:Place,schema:Product,schema:Service)
>
> *Does a Certification have a logo? should it? Do we try to say that
> anywhere?*
>
> Let's figure out the 'name' stuff first!
>
> /cc @MatthiasWiesmann <https://github.com/MatthiasWiesmann> @alex-jansen
> <https://github.com/alex-jansen> @RichardWallis
> <https://github.com/RichardWallis> @msporny <https://github.com/msporny>
> @philarcher <https://github.com/philarcher>
>
> —
> Reply to this email directly, view it on GitHub
> <#3441 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APYBL6ZJS5J4M2OX7YLHZRTYOUMAHAVCNFSM6AAAAABBOVAX3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGA2DQNRQHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Contributor
|
We should figure out what’s up with “name” but the examples can always be improved later; they’re not a recommendation or requirement |
Contributor
|
LGTM and it has had good review from relevant nearby projects. @alex-jansen can you draft a section for release notes? |
This was referenced May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3230