Added logic to un ruby tests from buildsite.py#3587
Merged
alex-jansen merged 2 commits intomainfrom Aug 22, 2024
Merged
Conversation
Added option to run ruby tests from the buildsite.py script. Cleaned up buildsite.py and localrubycheck.sh * localrubycheck has a proper hash-bang. * buildsite.py uses python facilities to manipulate paths. * buildsite.py does not do blind execs with globs and pipes, as much as possible, processing is done in Python.
Contributor
pascalfleury
left a comment
pascalfleury
left a comment
There was a problem hiding this comment.
just a few comments.
pascalfleury
approved these changes
Aug 22, 2024
Contributor
pascalfleury
left a comment
pascalfleury
left a comment
There was a problem hiding this comment.
Looks good, thanks!
pascalfleury
approved these changes
Aug 22, 2024
alex-jansen
approved these changes
Aug 22, 2024
Contributor
alex-jansen
left a comment
alex-jansen
left a comment
There was a problem hiding this comment.
nice option to include the ruby tests in local builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to run ruby tests from the buildsite.py script. Cleaned up buildsite.py and localrubycheck.sh
localrubycheck.shhas a proper hash-bang.buildsite.pyuses python facilities to manipulate paths.buildsite.pydoes not do blind execs with globs and pipes, as much as possible, processing is done in Python.