Closed
Conversation
Contributor
MatthiasWiesmann
commented
Aug 23, 2024
MatthiasWiesmann
commented
- Remove unused code.
- Moved logger into class (instead of globals).
* Remove unused code. * Moved logger into class (instead of globals).
pascalfleury
approved these changes
Aug 23, 2024
Contributor
pascalfleury
left a comment
pascalfleury
left a comment
There was a problem hiding this comment.
Mostly nits at this point, but some comments for future improvements.
Playgirlkaybraz11
approved these changes
Aug 25, 2024
pascalfleury
approved these changes
Aug 26, 2024
pascalfleury
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.