Skip to content

Fix imports and breakage#3646

Merged
alex-jansen merged 8 commits intomainfrom
main_help
Sep 30, 2024
Merged

Fix imports and breakage#3646
alex-jansen merged 8 commits intomainfrom
main_help

Conversation

@MatthiasWiesmann
Copy link
Contributor

@MatthiasWiesmann MatthiasWiesmann commented Sep 27, 2024

Fix the various imports and the breakage introduced by the changes in the script directory.

  • All imports are now done relative from the root.
  • All imports are done at the start of the module, so we get errors immediately.
  • Fixed various breakage.
  • Only module/libraries are imported.
  • Moved pretty logging into its own file.
  • Added a context managed to log entry/exit of a particular task.
  • Uncommented some logging statements.
  • Ran the ruff formatter on all files.
  • Removed superfluous log initialisation statements.

@MatthiasWiesmann MatthiasWiesmann added the python Pull requests that update Python code label Sep 27, 2024
Copy link
Contributor

@pascalfleury pascalfleury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have welcomed a review for just the formatting changes before the fix.

@alex-jansen alex-jansen merged commit 0e6c593 into main Sep 30, 2024
@alex-jansen alex-jansen deleted the main_help branch September 30, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants